Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Sowmini Varadhan
On (10/17/16 12:49), Alexander Duyck wrote: > >> > /* Currently only IPv4/IPv6 with TCP is supported */ > >> > switch (hdr.ipv4->version) { > >> > case IPVERSION: > >> > /* access ihl as u8 to avoid unaligned access on ia64 */ > >> > hlen = (h

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Alexander Duyck
On Mon, Oct 17, 2016 at 12:18 PM, Sowmini Varadhan wrote: > On (10/17/16 11:15), Alexander Duyck wrote: >> I would say you probably only need the first check here for skb->data >> and could probably skip the second part. You will be testing for >> skb_tail_pointer in all the other tests you added

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Sowmini Varadhan
On (10/17/16 11:15), Alexander Duyck wrote: > I would say you probably only need the first check here for skb->data > and could probably skip the second part. You will be testing for > skb_tail_pointer in all the other tests you added so this check is > redundant anyway. > > Also you might want t

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Alexander Duyck
On Mon, Oct 17, 2016 at 10:25 AM, Sowmini Varadhan wrote: > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > passed down an sk_buff that has the network and transport > header in the paged data, so it needs to make sure these > headers are available in the headlen bytes to calculate the