On 2015/10/23 13:46, ND Linux CI Server wrote: ... > checkpatch.pl has some complaints: > > -------------------------------------------------------------------------------- > > checkpatch.pl results for patch "[PATCH 2/4] e1000e: Add ndo_enc_hdr_len" > > WARNING:LONG_LINE: line over 80 characters > #53: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:3981: > + if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) > { > > WARNING:LONG_LINE: line over 80 characters > #62: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4000: > + if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) > { > > WARNING:LONG_LINE: line over 80 characters > #71: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4014: > + if (adapter->max_frame_size <= VLAN_ETH_FRAME_LEN + > ETH_FCS_LEN) { > > total: 0 errors, 3 warnings, 0 checks, 184 lines checked
I was aware of these warnings but my understanding was that lines without over 80 characters are not mandatory requirement and a short overrun can be acceptable, like 81 or 82... Not sure what made me think so, though. Anyway, I will fix these warnings. Thanks, Toshiaki Makita -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html