RE: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-15 Thread Brown, Aaron F
> > [ cut here ] > > WARNING: CPU: 1 PID: 0 at net/sched/sch_generic.c:316 > dev_watchdog+0x1c2/0x1d0 > > NETDEV WATCHDOG: eth1 (e1000): transmit queue 0 timed out > > Thanks a lot for the tests! Really appreciate it. np, I needed to get my old compatibility systems back i

Re: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-14 Thread John Fastabend
M >>> To: bbla...@plumgrid.com; john.fastab...@gmail.com; >>> alexei.starovoi...@gmail.com; Kirsher, Jeffrey T >>> ; bro...@redhat.com; da...@davemloft.net >>> Cc: xiyou.wangc...@gmail.com; intel-wired-...@lists.osuosl.org; >>> u9012...@gmail.com; netdev@v

Re: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-14 Thread Alexei Starovoitov
com; > > alexei.starovoi...@gmail.com; Kirsher, Jeffrey T > > ; bro...@redhat.com; da...@davemloft.net > > Cc: xiyou.wangc...@gmail.com; intel-wired-...@lists.osuosl.org; > > u9012...@gmail.com; netdev@vger.kernel.org > > Subject: [Intel-wired-lan] [net-next PATCH v3 1/

RE: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-14 Thread Brown, Aaron F
a...@davemloft.net > Cc: xiyou.wangc...@gmail.com; intel-wired-...@lists.osuosl.org; > u9012...@gmail.com; netdev@vger.kernel.org > Subject: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes > regardless of skb or not > > The BQL API does not reference the sk_buff nor

Re: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-13 Thread Alexander Duyck
On Mon, Sep 12, 2016 at 9:25 PM, Tom Herbert wrote: > On Mon, Sep 12, 2016 at 8:00 PM, Alexander Duyck > wrote: >> On Mon, Sep 12, 2016 at 3:13 PM, John Fastabend >> wrote: >>> The BQL API does not reference the sk_buff nor does the driver need to >>> reference the sk_buff to calculate the lengt

Re: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-12 Thread Tom Herbert
On Mon, Sep 12, 2016 at 8:00 PM, Alexander Duyck wrote: > On Mon, Sep 12, 2016 at 3:13 PM, John Fastabend > wrote: >> The BQL API does not reference the sk_buff nor does the driver need to >> reference the sk_buff to calculate the length of a transmitted frame. >> This patch removes an sk_buff re

Re: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-12 Thread Alexander Duyck
On Mon, Sep 12, 2016 at 3:13 PM, John Fastabend wrote: > The BQL API does not reference the sk_buff nor does the driver need to > reference the sk_buff to calculate the length of a transmitted frame. > This patch removes an sk_buff reference from the xmit irq path and > also allows packets sent fr