RE: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-14 Thread Brown, Aaron F
;xiyou.wangc...@gmail.com>; David S. Miller <da...@davemloft.net> > Subject: Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP > support > > Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > > > On Tue, Sep 13, 2016 at 07:14:27PM +0

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Rustad, Mark D
Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 10:41:12PM +, Rustad, Mark D wrote: That said, I can see that you have tried to keep the original code path pretty much intact. I would note that you introduced rcu calls into the !bpf path that would never

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Alexei Starovoitov
On Tue, Sep 13, 2016 at 10:41:12PM +, Rustad, Mark D wrote: > That said, I can see that you have tried to keep the original code path > pretty much intact. I would note that you introduced rcu calls into the !bpf > path that would never have been done before. While that should be ok, I > would

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Francois Romieu
Rustad, Mark D : > Alexei Starovoitov wrote: [...] > > the point that it's only used virtualized, since PCI (not PCIE) have > > been long dead. > > My point is precisely the opposite. It is a real device, it exists in real > systems and it

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Rustad, Mark D
Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 07:14:27PM +, Rustad, Mark D wrote: Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: Alexei Starovoitov

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Alexei Starovoitov
On Tue, Sep 13, 2016 at 07:14:27PM +, Rustad, Mark D wrote: > Alexei Starovoitov wrote: > > >On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: > >>Alexei Starovoitov wrote: > >> > >>>I've looked through qemu and it

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Rustad, Mark D
Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: Alexei Starovoitov wrote: I've looked through qemu and it appears only emulate e1k and tg3. The latter is still used in the field, so the

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Alexei Starovoitov
On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: > Alexei Starovoitov wrote: > > >I've looked through qemu and it appears only emulate e1k and tg3. > >The latter is still used in the field, so the risk of touching > >it is higher. > > I have no idea

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Rustad, Mark D
Alexei Starovoitov wrote: I've looked through qemu and it appears only emulate e1k and tg3. The latter is still used in the field, so the risk of touching it is higher. I have no idea what makes you think that e1k is *not* "used in the field". I grant you it

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-13 Thread Alexei Starovoitov
On Mon, Sep 12, 2016 at 08:42:41PM -0700, Alexander Duyck wrote: > On Mon, Sep 12, 2016 at 3:13 PM, John Fastabend > wrote: > > From: Alexei Starovoitov > > > > This patch adds initial support for XDP on e1000 driver. Note e1000 > > driver does not support

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-12 Thread Alexander Duyck
On Mon, Sep 12, 2016 at 3:13 PM, John Fastabend wrote: > From: Alexei Starovoitov > > This patch adds initial support for XDP on e1000 driver. Note e1000 > driver does not support page recycling in general which could be > added as a further improvement.