Re: [NET]: Added GSO header verification

2006-06-29 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 27 Jun 2006 19:07:24 -0700 On Wed, 2006-06-28 at 08:31 +1000, Herbert Xu wrote: [NET]: Fix logical error in skb_gso_ok The test in skb_gso_ok is backwards. Noticed by Michael Chan [EMAIL PROTECTED]. Signed-off-by: Herbert Xu [EMAIL

[NET]: Added GSO header verification

2006-06-27 Thread Herbert Xu
Hi Dave: This feature is only needed by Xen but most of the code here is useful for other things like TCPv4 ECN support. [NET]: Added GSO header verification When GSO packets come from an untrusted source (e.g., a Xen guest domain), we need to verify the header integrity before passing

Re: [NET]: Added GSO header verification

2006-06-27 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 27 Jun 2006 22:07:14 +1000 This feature is only needed by Xen but most of the code here is useful for other things like TCPv4 ECN support. [NET]: Added GSO header verification Looks sane, applied. Thanks Herbert. - To unsubscribe from this list

Re: [NET]: Added GSO header verification

2006-06-27 Thread Michael Chan
On Tue, 2006-06-27 at 22:07 +1000, Herbert Xu wrote: [NET]: Added GSO header verification @@ -2166,10 +2166,14 @@ struct sk_buff *tcp_tso_segment(struct s if (!pskb_may_pull(skb, thlen)) goto out; + segs = NULL; + if (skb_gso_ok(skb, features

Re: [NET]: Added GSO header verification

2006-06-27 Thread Herbert Xu
On Tue, Jun 27, 2006 at 01:46:35PM -0700, Michael Chan wrote: On Tue, 2006-06-27 at 22:07 +1000, Herbert Xu wrote: [NET]: Added GSO header verification @@ -2166,10 +2166,14 @@ struct sk_buff *tcp_tso_segment(struct s if (!pskb_may_pull(skb, thlen)) goto out