Re: [NET] IPv6 oops bisected

2007-10-08 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Sun, 07 Oct 2007 10:56:07 -0400 /etc/sysconfig/network-scripts/network-functions-ipv6: line 246: 1760 Killed LC_ALL=C /sbin/ip $options NULL pointer dereference at 0x03f8 backtrace: :ipv6:ip6_route_add+0x1b1/0x543 'dev' can be NULL

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Herbert Xu
On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1188,7 +1188,7 @@ int ip6_route_add(struct fib6_config *cfg) if ((cfg-fc_flags RTF_REJECT) ||

Re: [NET] IPv6 oops bisected

2007-10-08 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 14:19:42 +0800 On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1188,7 +1188,7 @@ int

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Denis V. Lunev
David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 14:19:42 +0800 On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@

Re: [NET] IPv6 oops bisected

2007-10-08 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:34:23 +0400 OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained thoroughly in this thread. When 'dev' is NULL in ip6_route_add() we need

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Denis V. Lunev
David Miller wrote: From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:34:23 +0400 OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained thoroughly in this thread. When 'dev' is

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Eric W. Biederman
Denis V. Lunev [EMAIL PROTECTED] writes: David Miller wrote: From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:34:23 +0400 OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained

[NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add(). Platform: x86-64

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add().

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Denis V. Lunev
Jeff Garzik wrote: Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
Denis V. Lunev wrote: Jeff Garzik wrote: Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible