[NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Thomas Graf
Account for the netlink message header size directly in nlmsg_new() instead of relying on the caller calculate it correctly. Replaces error handling of message construction functions when constructing notifications with bug traps since a failure implies a bug in calculating the size of the skb.

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Paul Moore
Thomas Graf wrote: Account for the netlink message header size directly in nlmsg_new() instead of relying on the caller calculate it correctly. Replaces error handling of message construction functions when constructing notifications with bug traps since a failure implies a bug in

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Fri, 10 Nov 2006 11:04:14 -0500 Thomas Graf wrote: Account for the netlink message header size directly in nlmsg_new() instead of relying on the caller calculate it correctly. Replaces error handling of message construction functions when

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Thomas Graf
* Paul Moore [EMAIL PROTECTED] 2006-11-10 11:04 I like this approach, it makes much more sense to me then the previous implementation which was a simple alias to alloc_skb(). Also, the NetLabel relevant sections look fine to me. Question is wheter to do the same for genetlink and add

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Paul Moore
Thomas Graf wrote: * Paul Moore [EMAIL PROTECTED] 2006-11-10 11:04 I like this approach, it makes much more sense to me then the previous implementation which was a simple alias to alloc_skb(). Also, the NetLabel relevant sections look fine to me. Question is wheter to do the same for