Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-08 Thread Simon Horman
On Wed, Jul 08, 2015 at 11:17:52PM +0200, Eric Dumazet wrote: > On Wed, 2015-07-08 at 13:56 -0700, Alex Gartrell wrote: > > On Tue, Jul 7, 2015 at 6:33 PM, Simon Horman wrote: > > > > > Is there any possibility you could investigate which stable trees are > > > effected by this bug? > > > > Well

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-08 Thread Eric Dumazet
On Wed, 2015-07-08 at 13:56 -0700, Alex Gartrell wrote: > On Tue, Jul 7, 2015 at 6:33 PM, Simon Horman wrote: > > > Is there any possibility you could investigate which stable trees are > > effected by this bug? > > Well this was certainly a problem in 3.10 (we had our own hacky > solution at th

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-08 Thread Alex Gartrell
On Tue, Jul 7, 2015 at 6:33 PM, Simon Horman wrote: > Is there any possibility you could investigate which stable trees are > effected by this bug? Well this was certainly a problem in 3.10 (we had our own hacky solution at the time) and every kernel since then would have also had this problem.

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-07 Thread Simon Horman
On Sun, Jul 05, 2015 at 09:14:38PM -0700, Alex Gartrell wrote: > On Sun, Jul 5, 2015 at 8:50 PM, Simon Horman wrote: > > Is it possible to get a 'Fixes:' tag? > > I suppose it'd be appropriate to say > > Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.") > > As that is what introduces tcp ea

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
On Sun, Jul 5, 2015 at 8:50 PM, Simon Horman wrote: > Is it possible to get a 'Fixes:' tag? I suppose it'd be appropriate to say Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.") As that is what introduces tcp early_demux, but that's just a guess as I haven't bisected it (not even sure my t

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Simon Horman
On Sun, Jul 05, 2015 at 03:19:27PM -0700, Alex Gartrell wrote: > On Sun, Jul 5, 2015 at 3:13 PM, Julian Anastasov wrote: > > May be the patch fixes crashes? If yes, Simon > > should apply it for ipvs/net tree, otherwise after > > the merge window... > > Yeah this is definitely a crash-fix

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
On Sun, Jul 5, 2015 at 3:13 PM, Julian Anastasov wrote: > May be the patch fixes crashes? If yes, Simon > should apply it for ipvs/net tree, otherwise after > the merge window... Yeah this is definitely a crash-fix and it's existed since at least 3.10. -- Alex Gartrell -- To unsubscrib

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Julian Anastasov
Hello, On Sun, 5 Jul 2015, Alex Gartrell wrote: > It is possible that we bind against a local socket in early_demux when we > are actually going to want to forward it. In this case, the socket serves > no purpose and only serves to confuse things (particularly functions which > implicit

[PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
It is possible that we bind against a local socket in early_demux when we are actually going to want to forward it. In this case, the socket serves no purpose and only serves to confuse things (particularly functions which implicitly expect sk_fullsock to be true, like ip_local_out). Additionally,