Re: [PATCH]: e1000 endianness bugs

2006-03-16 Thread Jeff Garzik
David S. Miller wrote: return -E_NO_BIG_ENDIAN_TESTING; [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

Re: [PATCH]: e1000 endianness bugs

2006-03-15 Thread Christoph Hellwig
On Wed, Mar 15, 2006 at 02:26:28PM -0800, David S. Miller wrote: > > return -E_NO_BIG_ENDIAN_TESTING; > > [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. Could the e1000 maintainers please add endianess annotations so that sparse will catch such things in the future?

Re: [PATCH]: e1000 endianness bugs

2006-03-15 Thread David S. Miller
From: "Jesse Brandeburg" <[EMAIL PROTECTED]> Date: Wed, 15 Mar 2006 15:33:43 -0800 > Yep, those look like bugs to me, thanks and congratulations, you're > the first person to test our PCI Express adapters in a big endian > system (they haven't been available before, and we don't have one, > yet)

Re: [PATCH]: e1000 endianness bugs

2006-03-15 Thread Jesse Brandeburg
On 3/15/06, David S. Miller <[EMAIL PROTECTED]> wrote: > > return -E_NO_BIG_ENDIAN_TESTING; > > [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> Yep, those look like bugs to me, thanks and congratulations, you're t

[PATCH]: e1000 endianness bugs

2006-03-15 Thread David S. Miller
return -E_NO_BIG_ENDIAN_TESTING; [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 5b7d0f4..1d91117 100644 --- a/drivers/net/e1000/e1