Re: [PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

2007-03-30 Thread Sridhar Samudrala
On Fri, 2007-03-30 at 09:13 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Thu, 29 Mar 2007 14:26:44 -0700 (PDT)), > David Miller <[EMAIL PROTECTED]> says: > > > From: Sridhar Samudrala <[EMAIL PROTECTED]> > > Date: Thu, 29 Mar 2007 14:17:28 -0700 > > > > > The check

Re: [PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

2007-03-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 29 Mar 2007 14:26:44 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: Sridhar Samudrala <[EMAIL PROTECTED]> > Date: Thu, 29 Mar 2007 14:17:28 -0700 > > > The check for length in rawv6_sendmsg() is incorrect. > > As len is an unsigned int, (len

Re: [PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

2007-03-29 Thread Sami Farin
On Thu, Mar 29, 2007 at 14:26:44 -0700, David Miller wrote: > From: Sridhar Samudrala <[EMAIL PROTECTED]> > Date: Thu, 29 Mar 2007 14:17:28 -0700 > > > The check for length in rawv6_sendmsg() is incorrect. > > As len is an unsigned int, (len < 0) will never be TRUE. > > I think checking for IPV6_M

Re: [PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

2007-03-29 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Thu, 29 Mar 2007 14:17:28 -0700 > The check for length in rawv6_sendmsg() is incorrect. > As len is an unsigned int, (len < 0) will never be TRUE. > I think checking for IPV6_MAXPLEN(65535) is better. > > Is it possible to send ipv6 jumbo packets

[PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

2007-03-29 Thread Sridhar Samudrala
The check for length in rawv6_sendmsg() is incorrect. As len is an unsigned int, (len < 0) will never be TRUE. I think checking for IPV6_MAXPLEN(65535) is better. Is it possible to send ipv6 jumbo packets using raw sockets? If so, we can remove this check. Thanks Sridhar Signed-off-by: Sridhar S