Re: [PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close()

2007-10-10 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 09 Oct 2007 14:50:54 +0400 > The unregister_netdevice() and dev_change_net_namespace() > both check for dev->flags to be IFF_UP before calling the > dev_close(), but the dev_close() checks for IFF_UP itself, > so remove those unneeded checks.

Re: [PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close()

2007-10-09 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > One side effect of this patch: might_sleep() is now called unconditionally. That would be seem to be a good thing :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~he

Re: [PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close()

2007-10-09 Thread Pavel Emelyanov
Jeff Garzik wrote: > Pavel Emelyanov wrote: >> The unregister_netdevice() and dev_change_net_namespace() >> both check for dev->flags to be IFF_UP before calling the >> dev_close(), but the dev_close() checks for IFF_UP itself, >> so remove those unneeded checks. >> >> Signed-off-by: Pavel Emely

Re: [PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close()

2007-10-09 Thread Jeff Garzik
Pavel Emelyanov wrote: The unregister_netdevice() and dev_change_net_namespace() both check for dev->flags to be IFF_UP before calling the dev_close(), but the dev_close() checks for IFF_UP itself, so remove those unneeded checks. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff

[PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close()

2007-10-09 Thread Pavel Emelyanov
The unregister_netdevice() and dev_change_net_namespace() both check for dev->flags to be IFF_UP before calling the dev_close(), but the dev_close() checks for IFF_UP itself, so remove those unneeded checks. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/core/dev.c b/