答复: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS

2018-07-10 Thread Li,Rongqing
> -邮件原件- > 发件人: Eric Dumazet [mailto:eric.duma...@gmail.com] > 发送时间: 2018年7月8日 8:22 > 收件人: David Miller ; Li,Rongqing > > 抄送: netdev@vger.kernel.org > 主题: Re: [PATCH][net-next][v2] net: limit each hash list length to > MAX_GRO_SKBS > > > > On 07/

Re: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS

2018-07-07 Thread David Miller
From: Eric Dumazet Date: Sat, 7 Jul 2018 17:22:01 -0700 > Maybe gro_count should be replaced by a bitmask, so that we can > speed up napi_gro_flush(), since it now has to use 3 cache lines > (gro_hash[] size is 192 bytes) Something like this? diff --git a/include/linux/netdevice.h b/include/lin

Re: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS

2018-07-07 Thread Eric Dumazet
On 07/05/2018 03:20 AM, David Miller wrote: > From: Li RongQing > Date: Thu, 5 Jul 2018 14:34:32 +0800 > >> After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash >> table.")' there is 8 hash buckets, which allows more flows to be held for >> merging. but MAX_GRO_SKBS, the

Re: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS

2018-07-05 Thread David Miller
From: Li RongQing Date: Thu, 5 Jul 2018 14:34:32 +0800 > After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash > table.")' there is 8 hash buckets, which allows more flows to be held for > merging. but MAX_GRO_SKBS, the total held skb for merging, is 8 skb still, > limit the

[PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS

2018-07-04 Thread Li RongQing
After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash table.")' there is 8 hash buckets, which allows more flows to be held for merging. but MAX_GRO_SKBS, the total held skb for merging, is 8 skb still, limit the hash table performance. keep MAX_GRO_SKBS as 8 skb, but limit eac