Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

2018-03-22 Thread David Miller
From: Colin King Date: Wed, 21 Mar 2018 19:34:58 + > From: Colin Ian King > > The current logic of flags | TUNNEL_SEQ is always non-zero and hence > sequence numbers are always incremented no matter the setting of the > TUNNEL_SEQ bit. Fix this by using & instead of |. > > Detected by Cov

Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

2018-03-21 Thread William Tu
On Wed, Mar 21, 2018 at 12:34 PM, Colin King wrote: > From: Colin Ian King > > The current logic of flags | TUNNEL_SEQ is always non-zero and hence > sequence numbers are always incremented no matter the setting of the > TUNNEL_SEQ bit. Fix this by using & instead of |. > > Detected by CoverityS

[PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

2018-03-21 Thread Colin King
From: Colin Ian King The current logic of flags | TUNNEL_SEQ is always non-zero and hence sequence numbers are always incremented no matter the setting of the TUNNEL_SEQ bit. Fix this by using & instead of |. Detected by CoverityScan, CID#1466039 ("Operands don't affect result") Fixes: 77a5196