[PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

2015-12-28 Thread Ivan Safonov
((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal for X >= 0. Signed-off-by: Ivan Safonov --- drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

2015-12-28 Thread Joe Perches
On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: > ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal > for X >= 0. X is not guaranteed to be >= 0 here > Signed-off-by: Ivan Safonov > --- >  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c |

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

2015-12-28 Thread Ivan Safonov
On 12/29/2015 12:56 AM, Joe Perches wrote: On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal for X >= 0. X is not guaranteed to be >= 0 here X is fixed constant. In this case X is {0, 1, 2}. @@ -4097,16

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

2015-12-28 Thread Ivan Safonov
On 12/29/2015 07:31 AM, Joe Perches wrote: On Tue, 2015-12-29 at 01:38 +0700, Ivan Safonov wrote: On 12/29/2015 12:56 AM, Joe Perches wrote: On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal for X >= 0. X is

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

2015-12-28 Thread Joe Perches
On Tue, 2015-12-29 at 01:38 +0700, Ivan Safonov wrote: > On 12/29/2015 12:56 AM, Joe Perches wrote: > > On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: > > > ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == > > > X) are equal for X >= 0. > > X is not guaranteed to be >= 0