On Fri, 21 Dec 2007 22:58:04 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote:
> In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 22:49:59 +0900), "Satoru
> SATOH" <[EMAIL PROTECTED]> says:
>
> > I agree.
> >
> > I mistakenly thought hz in that context must be larger than 1000.
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 22:49:59 +0900), "Satoru
SATOH" <[EMAIL PROTECTED]> says:
> I agree.
>
> I mistakenly thought hz in that context must be larger than 1000..
> As it's uncertain, your's looks much simpler and better.
>
> (btw, the lines "else div = 1" is n
I agree.
I mistakenly thought hz in that context must be larger than 1000..
As it's uncertain, your's looks much simpler and better.
(btw, the lines "else div = 1" is not needed, is it?)
Thanks,
Satoru SATOH
2007/12/21, YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]>:
(snip)
> Why don't you s
On Fri, 21 Dec 2007, YOSHIFUJI Hideaki wrote:
> In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 11:24:54 +0900), "Satoru
> SATOH" <[EMAIL PROTECTED]> says:
>
> > 2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>:
> > > Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
> > > ...
> > >
> > > > but
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 11:24:54 +0900), "Satoru
SATOH" <[EMAIL PROTECTED]> says:
> 2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>:
> > Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
> > ...
> >
> > > but since it's your patch, I hope you do some additional checking
>
On 21-12-2007 03:24, Satoru SATOH wrote:
> 2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>:
>> Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
>> ...
>>
>>> but since it's your patch, I hope you do some additional checking
>>> if it's always like this...
>>
>> ...or maybe only changing this all a li
2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>:
> Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
> ...
>
> > but since it's your patch, I hope you do some additional checking
> > if it's always like this...
>
>
> ...or maybe only changing this all a little bit will make it look safer!
>
> Jarek P.
Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
...
> but since it's your patch, I hope you do some additional checking
> if it's always like this...
...or maybe only changing this all a little bit will make it look safer!
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe net
Satoru SATOH wrote, On 12/20/2007 05:21 PM:
> i see. HZ can be < 1000.. i should be wrong.
>
> however, i got the following,
>
> [root iproute2.org]# ./ip/ip route change 192.168.140.0/24 dev eth1 rto_min 4s
> [root iproute2.org]# gdb -q ./ip/ip
...
> (gdb) p hz
> $1 = 10
That's why
i see. HZ can be < 1000.. i should be wrong.
however, i got the following,
[root iproute2.org]# ./ip/ip route change 192.168.140.0/24 dev eth1 rto_min 4s
[root iproute2.org]# gdb -q ./ip/ip
Using host libthread_db library "/lib/libthread_db.so.1".
(gdb) br iproute.c:512
Breakpoint 1 at 0x804fc8d:
On 20-12-2007 04:31, Satoru SATOH wrote:
> "ip route show" does not print correct value when larger rto_min is
> set (e.g. 3sec).
>
> This problem is because of overflow in print_route() and
> the patch below is a workaround fix for that.
>
...
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -510,
In article <[EMAIL PROTECTED]> (at Thu, 20 Dec 2007 12:31:27 +0900), "Satoru
SATOH" <[EMAIL PROTECTED]> says:
> diff --git a/ip/iproute.c b/ip/iproute.c
> index f4200ae..fa722c6 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -510,16 +510,16 @@ int print_route(const struct sockaddr_nl *who,
"ip route show" does not print correct value when larger rto_min is
set (e.g. 3sec).
This problem is because of overflow in print_route() and
the patch below is a workaround fix for that.
[root test]# ./iproute2.git.org/ip/ip route show dev eth1
192.168.140.0/24 proto kernel scope link src 192
13 matches
Mail list logo
