Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 25 Apr 2007 07:49:32 +0900 (JST) > [TCP]: Fix linkage errors on i386. > > To avoid raw division, use ktime_to_timeval() to get usec. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> This one looks good to me, patch applied.

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 25 Apr 2007 00:15:15 +0200), Thomas Gleixner <[EMAIL PROTECTED]> says: > On Tue, 2007-04-24 at 14:57 -0700, Stephen Hemminger wrote: > > On Wed, 25 Apr 2007 06:55:39 +0900 (JST) > > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > > > > > In article

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2007 00:12:38 +0200 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Stephen Hemminger a écrit : > > On Wed, 25 Apr 2007 06:55:39 +0900 (JST) > > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > > > >> In article <[EMAIL PROTECTED]> (at Tue, 24 Apr 2007 10:04:20 -0700), > >> Stephe

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Eric Dumazet
Stephen Hemminger a écrit : On Wed, 25 Apr 2007 06:55:39 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: In article <[EMAIL PROTECTED]> (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen Hemminger <[EMAIL PROTECTED]> says: Yoshifuji-san had the right idea, but ktime_to_us needs t

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Thomas Gleixner
On Tue, 2007-04-24 at 14:57 -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2007 06:55:39 +0900 (JST) > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > > > In article <[EMAIL PROTECTED]> (at Tue, 24 Apr 2007 10:04:20 -0700), > > Stephen Hemminger <[EMAIL PROTECTED]> says: > > > > > Yoshi

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2007 06:55:39 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > In article <[EMAIL PROTECTED]> (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen > Hemminger <[EMAIL PROTECTED]> says: > > > Yoshifuji-san had the right idea, but ktime_to_us needs to be defined > > in a

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen Hemminger <[EMAIL PROTECTED]> says: > Yoshifuji-san had the right idea, but ktime_to_us needs to be defined > in a way that works on both 64 and 32bit platforms. No, this does not cure. > > +#define ktime_to_us(kt)

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 24 Apr 2007 20:48:22 +0200 > Stephen Hemminger a écrit : > > > > +#define ktime_to_us(kt)((kt).tv64 / NSEC_PER_SEC) > > + > > #else > > Oh dear... how many bogus patches are going to be posted today ? Stephen please submit

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Eric Dumazet
Stephen Hemminger a écrit : +#define ktime_to_us(kt) ((kt).tv64 / NSEC_PER_SEC) + #else Oh dear... how many bogus patches are going to be posted today ? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Adrian Bunk
On Tue, Apr 24, 2007 at 10:04:20AM -0700, Stephen Hemminger wrote: >... > +/** > + * ktime_to_us - convert a ktime_t variable to scalar microseconds > + * @kt: the ktime_t variable to convert > + * > + * Returns the scalar nanoseconds representation of @kt > + */ > +static inline s64 k

[PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread Stephen Hemminger
Yoshifuji-san had the right idea, but ktime_to_us needs to be defined in a way that works on both 64 and 32bit platforms. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/ktime.h | 13 + net/ipv4/tcp_illinois.c |2 +- net/ipv4/tcp_lp.c |2 +- ne