Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-15 Thread Julian Anastasov
Hello, On Wed, 14 Nov 2007, Simon Horman wrote: So, as long as these entries are not accessible from sysctl it is safe to run without strategy handler but if values can be changed then we will need strategy handler to properly call update_defense_level() as done in

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Tue, Nov 13, 2007 at 02:45:00AM -0800, David Miller wrote: From: Christian Borntraeger [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 11:29:58 +0100 Running the latest git code I get the following messages during boot: sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Eric W. Biederman
Simon Horman [EMAIL PROTECTED] writes: Hi Christian, Hi Dave, I have indeed been looking into this of late. Assuming that you use of CTL_UNNUMBERED is correct, this patch looks fine to me. Acked. I was planning to do the same and also switch over all the other entries over to use

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Julian Anastasov
Hello, On Tue, 13 Nov 2007, Simon Horman wrote: Running the latest git code I get the following messages during boot: sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing strategy [...] sysctl table check failed: /net/ipv4/vs/drop_packet

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Eric W. Biederman
Julian Anastasov [EMAIL PROTECTED] writes: I assume /proc/sys is still valid place, only sysctl interface is scheduled for removal. Yes. The ascii versions of the sysctls that show up in /proc/sys are definitely still valid. So, as long as these entries are not accessible from sysctl

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: Hi Julian, On Tue, 13 Nov 2007, Simon Horman wrote: [snip] As for the commented out entries. They are supposed to be exposed by some other means - I believe the thinking was to comply with the don't expose stuff in proc

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Eric W. Biederman
Simon Horman [EMAIL PROTECTED] writes: On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: Hi Julian, On Tue, 13 Nov 2007, Simon Horman wrote: [snip] As for the commented out entries. They are supposed to be exposed by some other means - I believe the thinking was to

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Wed, Nov 14, 2007 at 06:25:00PM -0700, Eric W. Biederman wrote: Simon Horman [EMAIL PROTECTED] writes: On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: Hi Julian, On Tue, 13 Nov 2007, Simon Horman wrote: [snip] As for the commented out entries. They are

[PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-13 Thread Christian Borntraeger
Running the latest git code I get the following messages during boot: sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing strategy [...] sysctl table check failed: /net/ipv4/vs/drop_packet .3.5.21.5 Missing strategy [...] sysctl table check failed:

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-13 Thread David Miller
From: Christian Borntraeger [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 11:29:58 +0100 Running the latest git code I get the following messages during boot: sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing strategy [...] sysctl table check failed: