Hi,
Marvell released a GPL driver for their 8388 wireless chip for USB
interface back in April.
The 8388 is the device being used by the OLPC laptop.
We have been working on cleaning it up for mainline inclusion. I think
the moment for wider review has arrived.
Since the diff is pretty large (
On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote:
> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote:
> >--- a/include/net/ieee80211_radiotap.h
> >+++ b/include/net/ieee80211_radiotap.h
> >@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header {
> > * Unitless indication of th
On Friday 15 December 2006 17:51, Marcelo Tosatti wrote:
>--- a/include/net/ieee80211_radiotap.h
>+++ b/include/net/ieee80211_radiotap.h
>@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header {
> * Unitless indication of the Rx/Tx antenna for this packet.
> * The first antenna is antenn
David Young wrote:
> On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote:
>> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote:
>>> --- a/include/net/ieee80211_radiotap.h
>>> +++ b/include/net/ieee80211_radiotap.h
>>> @@ -168,6 +168,23 @@ struct ieee80211_radiotap_header {
>>> *
Sam Leffler wrote:
> David Young wrote:
>> On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote:
>>> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote:
--- a/include/net/ieee80211_radiotap.h
+++ b/include/net/ieee80211_radiotap.h
@@ -168,6 +168,23 @@ struct ieee80211_radi
> > > /* Channel flags. */
> > Did you send this part to netbsd also? We really don't want to fork
> > radiotap. ;) Also, this should be in a separate patch, but I'm guessing
> > it's
> > all rolled together for convenience.
>
> No, especially since NetBSD is where I keep the authoritative def
Announcing an updated patch of the Marvell Libertas 8388 802.11 USB
driver.
Diff can be found at
http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
_Please_ review, this driver is targeted for mainline inclusion.
There have been almost no comments resulting from the first submission.
On Mon, Dec 18, 2006 at 05:57:23PM -0200, Marcelo Tosatti wrote:
>
> > > > /* Channel flags. */
> > > Did you send this part to netbsd also? We really don't want to fork
> > > radiotap. ;) Also, this should be in a separate patch, but I'm guessing
> > > it's
> > > all rolled together for conven
Hi,
Here goes an updated patch of the Marvell Libertas 8388 802.11 USB
driver, addressing pretty much all comments from Arnd (the remaining
ones are listed in TODO entry below).
Diff can be found at
http://dev.laptop.org/~marcelo/libertas-8388-10022007.patch
Please review.
TODO:
- In places wh
On Tuesday 16 January 2007 19:55, you wrote:
> Announcing an updated patch of the Marvell Libertas 8388 802.11 USB
> driver.
>
> Diff can be found at
> http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
Is core chip somehow close to pci/pci-e:
00:07.0 Ethernet controller: Marvell Technol
On Tue, 2007-01-16 at 20:32 +0100, Arkadiusz Miskiewicz wrote:
> On Tuesday 16 January 2007 19:55, you wrote:
> > Announcing an updated patch of the Marvell Libertas 8388 802.11 USB
> > driver.
> >
> > Diff can be found at
> > http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
>
> Is core
On Tue, 2007-01-16 at 16:55 -0200, Marcelo Tosatti wrote:
> _Please_ review, this driver is targeted for mainline inclusion.
>
> There have been almost no comments resulting from the first submission.
We had looked over the previous version a few days ago and noticed that
the biggest part of the
On Tue, 16 Jan 2007 16:55:24 -0200, Marcelo Tosatti wrote:
> Diff can be found at
> http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
>
> _Please_ review, this driver is targeted for mainline inclusion.
As long as there is yet another 802.11 stack inside, your chances to
get this inclu
On Wed, 2007-01-17 at 14:11 +0100, Jiri Benc wrote:
> On Tue, 16 Jan 2007 16:55:24 -0200, Marcelo Tosatti wrote:
> > Diff can be found at
> > http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
> >
> > _Please_ review, this driver is targeted for mainline inclusion.
>
> As long as there
On Wed, 2007-01-17 at 10:01 -0500, Dan Williams wrote:
> The part is a mostly fullmac part that until now has been targetted at
> the embedded market (PSP, N80 phone, etc). That means that the driver
> shouldn't be too large (airo is about 8000 kLOC without airo_cs) but for
> some reason it still
On Wed, 17 Jan 2007 10:01:12 -0500, Dan Williams wrote:
> But could we please be constructive here, and actually take a look at
> the driver and point out problems?
Just from a quick glance:
- drivers/net/wireless/libertas/radiotap.h file with a lot of constants
already defined elsewhere (and n
On Wed, 2007-01-17 at 15:18 +, Johannes Berg wrote:
> On Wed, 2007-01-17 at 10:01 -0500, Dan Williams wrote:
>
> > The part is a mostly fullmac part that until now has been targetted at
> > the embedded market (PSP, N80 phone, etc). That means that the driver
> > shouldn't be too large (airo
On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote:
> I said "mostly" fullmac. Sort of like ipw2100 (IIRC) is softmac but it
> does all the association stuff in firmware. It doesn't fit fullmac, but
> it's a lot more fullmac than atheros. There isn't any management frame
> processing, it doe
On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote:
> On Wed, 2007-01-17 at 15:18 +, Johannes Berg wrote:
> > On Wed, 2007-01-17 at 10:01 -0500, Dan Williams wrote:
> >
> > > The part is a mostly fullmac part that until now has been targetted at
> > > the embedded market (PSP, N80 phone, et
On Wed, 17 Jan 2007 12:43:08 -0500, Dan Williams wrote:
> The 8388 architecture is typical of a thick firmware architecture, where
> the firmware handles all 802.11 MAC management tasks. The host driver
> downloads standard 802.3 frames to the firmware to be transmitted over
> the link as 802.11 f
On Wed, Jan 17, 2007 at 07:52:13AM +, Johannes Berg wrote:
> On Tue, 2007-01-16 at 16:55 -0200, Marcelo Tosatti wrote:
>
> > _Please_ review, this driver is targeted for mainline inclusion.
> >
> > There have been almost no comments resulting from the first submission.
>
> We had looked over
On Wed, Jan 17, 2007 at 04:42:04PM -0200, Marcelo Tosatti wrote:
> And using the Marvell provided firmware is a requirement for OLPC
> machines, where the CPU will be shut down but the chip+firmware will
> continue to forward packets in the mesh network (there are extreme power
> saving constraints
On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote:
> Furthermore, I might add that the entire reason this part was chosen for
> OLPC was because it _is_ fullmac.
>
> To drive down power consumption, the OLPC puts the host CPU to sleep but
> keeps the 8388 powered on. That consumes arou
Christoph Hellwig wrote:
On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote:
Furthermore, I might add that the entire reason this part was chosen for
OLPC was because it _is_ fullmac.
To drive down power consumption, the OLPC puts the host CPU to sleep but
keeps the 8388 powered on.
On Wed, Jan 17, 2007 at 06:19:07PM -0500, Jeff Garzik wrote:
> Christoph Hellwig wrote:
> >On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote:
> >>allows the 8388 to continue routing other laptops' packets over the mesh
> >>*while the host CPU is asleep*.
> >
> >We're not going to put a
On Wed, 2007-01-17 at 23:09 +, Christoph Hellwig wrote:
> On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote:
> > Furthermore, I might add that the entire reason this part was chosen for
> > OLPC was because it _is_ fullmac.
> >
> > To drive down power consumption, the OLPC puts the
On Wed, 2007-01-17 at 23:06 +, Christoph Hellwig wrote:
> On Wed, Jan 17, 2007 at 04:42:04PM -0200, Marcelo Tosatti wrote:
> > And using the Marvell provided firmware is a requirement for OLPC
> > machines, where the CPU will be shut down but the chip+firmware will
> > continue to forward packe
On Thu, Jan 18, 2007 at 10:41:45AM -0500, Dan Williams wrote:
> In the future we'll likely need some layering to support the 8385
> SDIO/CF variant, but most likely not in way the USB support is currently
> excessively layered and abstracted.
Yeah. Let's summarize my unfortunately a bit too nasty
On 1/18/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
On Thu, Jan 18, 2007 at 10:41:45AM -0500, Dan Williams wrote:
> In the future we'll likely need some layering to support the 8385
> SDIO/CF variant, but most likely not in way the USB support is currently
> excessively layered and abstracte
On Thu, 2007-01-18 at 22:40 +, Christoph Hellwig wrote:
> On Thu, Jan 18, 2007 at 10:41:45AM -0500, Dan Williams wrote:
> > In the future we'll likely need some layering to support the 8385
> > SDIO/CF variant, but most likely not in way the USB support is currently
> > excessively layered and
On Thu, 2007-01-18 at 17:54 -0500, Jon Smirl wrote:
> On 1/18/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> > On Thu, Jan 18, 2007 at 10:41:45AM -0500, Dan Williams wrote:
> > > In the future we'll likely need some layering to support the 8385
> > > SDIO/CF variant, but most likely not in way
o <[EMAIL PROTECTED]>
In-Reply-To: <[EMAIL PROTECTED]>
Subject: Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)
Hi Jiri,
On Wed, Jan 17, 2007 at 07:07:26PM +0100, Jiri Benc wrote:
> On Wed, 17 Jan 2007 12:43:08 -0500, Dan Williams wrote:
> > The 8388 architecture is typ
ev , Jeff Garzik <[EMAIL PROTECTED]>,
"John W. Linville" <[EMAIL PROTECTED]>,
"Luis R. Rodriguez" <[EMAIL PROTECTED]>,
Arnd Bergmann <[EMAIL PROTECTED]>,
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
In-Reply-To: <[EMAIL PR
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote:
> On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote:
>
> > I said "mostly" fullmac. Sort of like ipw2100 (IIRC) is softmac but it
> > does all the association stuff in firmware. It doesn't fit fullmac, but
> > it's a lot more ful
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote:
> > 3) Could you enumerate your issues with the command dispatching? Right
> > now, many of the commands are blocking, which is suboptimal. This is an
> > artifact of the embedded history of the part. We need to eventually fix
> > t
On 1/22/07, Marcelo Tosatti <[EMAIL PROTECTED]> wrote:
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote:
> On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote:
>
> > I said "mostly" fullmac. Sort of like ipw2100 (IIRC) is softmac but it
> > does all the association stuff in firmwa
On Mon, 2007-01-22 at 10:20 -0500, Jon Smirl wrote:
> What is the general solution for 802.11s?
None yet.
> I'm working on an embedded
> design that would benefit from 11s support and I'd rather not have to
> roll my own mesh implementation in user space.
Well, there is no mesh implementation t
On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
On Mon, 2007-01-22 at 10:20 -0500, Jon Smirl wrote:
> What is the general solution for 802.11s?
None yet.
> I'm working on an embedded
> design that would benefit from 11s support and I'd rather not have to
> roll my own mesh implementation
On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote:
> Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed
> to be making changes at the very lowest MAC layers. It will be hard to
> be compatible with that from user space.
Good point, it's not possible to implement this without ch
On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote:
> Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed
> to be making changes at the very lowest MAC layers. It will be hard to
> be compatible with that from user space.
Goo
On Tue, 2007-01-23 at 12:14 -0500, Jon Smirl wrote:
> I haven't seen the 11s spec, are devices with softmac implementations
> flexible enough to implement it or do they need firmware changes too?
I'm pretty sure bcm43xx would need firmware changes.
johannes
signature.asc
Description: This is a
On Tue, 2007-01-23 at 12:14 -0500, Jon Smirl wrote:
> On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
> > On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote:
> >
> > > Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed
> > > to be making changes at the very lowest MAC layers.
On 1/23/07, Dan Williams <[EMAIL PROTECTED]> wrote:
On Tue, 2007-01-23 at 12:14 -0500, Jon Smirl wrote:
> On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
> > On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote:
> >
> > > Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed
> >
On Tue, 2007-01-23 at 12:59 -0500, Dan Williams wrote:
> I believe it needs to at least support 4 address frames, which usually
> requires firmware changes on fullmac cards, but fully softmac cards
> (atheros, broadcom) probably would not.
.11s also introduces new frame types/subtypes that probab
On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
On Tue, 2007-01-23 at 12:59 -0500, Dan Williams wrote:
> I believe it needs to at least support 4 address frames, which usually
> requires firmware changes on fullmac cards, but fully softmac cards
> (atheros, broadcom) probably would not.
.1
On Tue, 2007-01-23 at 19:30 +0100, Johannes Berg wrote:
> .11s also introduces new frame types/subtypes that probably need to be
> ACKed which usually the firmware won't do since it doesn't understand
> those frame types/subtypes yet.
This assertion might have been premature, it's entirely possib
On Thu, Jan 18, 2007 at 03:22:50AM -0500, John W. Linville wrote:
> On Wed, Jan 17, 2007 at 06:19:07PM -0500, Jeff Garzik wrote:
> > Christoph Hellwig wrote:
> > >On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote:
>
> > >>allows the 8388 to continue routing other laptops' packets over t
On Wed, 2007-01-24 at 13:26 -0200, Marcelo Tosatti wrote:
> On Thu, Jan 18, 2007 at 03:22:50AM -0500, John W. Linville wrote:
> > On Wed, Jan 17, 2007 at 06:19:07PM -0500, Jeff Garzik wrote:
> > > Christoph Hellwig wrote:
> > > >On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote:
> >
> >
On Wed, Jan 24, 2007 at 01:52:35PM -0500, Dan Williams wrote:
> I pushed for a general "lib80211" sort of thing at the Summit, which I
> think was agreed in principle with others like Intel. We need something
> to hold the bits that are common to d80211 and non-softmac drivers.
> These include sc
On Tuesday 16 January 2007 19:55, Marcelo Tosatti wrote:
>
> Announcing an updated patch of the Marvell Libertas 8388 802.11 USB
> driver.
>
> Diff can be found at
> http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
>
> _Please_ review, this driver is targeted for mainline inclusion.
Hi Jiri,
On Sat, Jan 20, 2007 at 06:15:54PM -0200, Marcelo Tosatti wrote:
> On Wed, Jan 17, 2007 at 04:43:28PM +0100, Jiri Benc wrote:
> > On Wed, 17 Jan 2007 10:01:12 -0500, Dan Williams wrote:
> > > But could we please be constructive here, and actually take a look at
> > > the driver and point
Hi Arnd,
On Sat, Jan 27, 2007 at 02:53:07AM +0100, Arnd Bergmann wrote:
> On Tuesday 16 January 2007 19:55, Marcelo Tosatti wrote:
> >
> > Announcing an updated patch of the Marvell Libertas 8388 802.11 USB
> > driver.
> >
> > Diff can be found at
> > http://dev.laptop.org/~marcelo/libertas-838
On Sat, Feb 03, 2007 at 08:43:49PM -0200, Marcelo Tosatti wrote:
> On Sat, Jan 27, 2007 at 02:53:07AM +0100, Arnd Bergmann wrote:
> > On Tuesday 16 January 2007 19:55, Marcelo Tosatti wrote:
> > > +#define ENTER() dprintk(1, "Enter: %s, %s:%i\n",
> > > __FUNCTION__, \
> > > +
On Monday 05 February 2007 15:01, John W. Linville wrote:
>
> > I disagree, entry/exit points have been shown to be useful in practice
> > to identify firmware problems on field.
>
> I'm not too fond of the ENTER/LEAVE stuff either. But, I do sympathize
> that they _can_ be useful in certain cir
On Mon, Feb 05, 2007 at 09:01:47AM -0500, John W. Linville wrote:
> > to identify firmware problems on field.
>
> I'm not too fond of the ENTER/LEAVE stuff either. But, I do sympathize
> that they _can_ be useful in certain circumstances/workflows/whatever.
>
> Is there an official "party line"
On Sat, Feb 03, 2007 at 08:43:49PM -0200, Marcelo Tosatti wrote:
> Hi Arnd,
> > Most of these are unused as well, I guess it would be good
> > to go through the whole list and see what can be removed.
>
> Done. Will go through the entire file list before posting the next
> patch.
Done.
> > Did
On Sat, Jan 27, 2007 at 02:53:07AM +0100, Arnd Bergmann wrote:
> > +/** Command Processing States and Options */
> > +#define HostCmd_STATE_IDLE0x
> > +#define HostCmd_STATE_IN_USE_BY_HOST 0x0001
> > +#define HostCmd_STATE_IN_USE_BY_MINIPORT 0x0002
> > +#define
57 matches
Mail list logo
