Re: [PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-14 Thread Erik Mouw
On Thu, Apr 13, 2006 at 10:29:19AM -0700, Stephen Hemminger wrote: On Thu, 13 Apr 2006 15:02:27 +0200 Erik Mouw [EMAIL PROTECTED] wrote: The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should be 15

Re: [PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-14 Thread Mitchell Blank Jr
Erik Mouw wrote: On Thu, Apr 13, 2006 at 10:29:19AM -0700, Stephen Hemminger wrote: Shouldn't compiler have gagged on this? Apparently not. At least the compiler I use doesn't warn about it (gcc version 3.3.5 (Debian 1:3.3.5-13)). Linus, this might be be something for sparse to check:

[PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-13 Thread Erik Mouw
The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should be 15 characters (16 including the trailing \0). This patch fixes that for the set_shortpreambl, get_shortpreambl, set_swencryption, and get_swencryption

Re: [PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 15:02:27 +0200 Erik Mouw [EMAIL PROTECTED] wrote: The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should be 15 characters (16 including the trailing \0). This patch fixes that for the