Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

2017-11-28 Thread Michael Chan
On Tue, Nov 28, 2017 at 7:56 AM, David Miller wrote: > From: Christophe JAILLET > Date: Tue, 21 Nov 2017 20:46:49 +0100 > >> Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a >> few lines above when reading the A0 portion

Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

2017-11-28 Thread David Miller
From: Christophe JAILLET Date: Tue, 21 Nov 2017 20:46:49 +0100 > Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a > few lines above when reading the A0 portion of the EEPROM. > The same should be done when reading the A2 portion of the

Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

2017-11-23 Thread David Miller
From: Christophe JAILLET Date: Tue, 21 Nov 2017 20:46:49 +0100 > Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a > few lines above when reading the A0 portion of the EEPROM. > The same should be done when reading the A2 portion of the

[PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

2017-11-21 Thread Christophe JAILLET
Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a few lines above when reading the A0 portion of the EEPROM. The same should be done when reading the A2 portion of the EEPROM. In order to correctly propagate an error, update 'rc' in this 2nd call as well, otherwise 0