Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-06 Thread David Miller
From: Michael Chan Date: Wed, 6 Dec 2017 11:16:55 -0800 > On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter > wrote: >> Smatch warns that: >> >> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() >> error:

Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-06 Thread Michael Chan
On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter wrote: > Smatch warns that: > > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() > error: uninitialized symbol 'rc'. > > "rc" is either uninitialized or set to zero here so we can just remove >

Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-06 Thread David Miller
From: Dan Carpenter Date: Tue, 5 Dec 2017 17:37:52 +0300 > Smatch warns that: > > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() > error: uninitialized symbol 'rc'. > > "rc" is either uninitialized or set to zero here so we can just

Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-05 Thread Dan Carpenter
I'm sorry, I left out that this applies to net-next. regards, dan carpenter

[PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-05 Thread Dan Carpenter
Smatch warns that: drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() error: uninitialized symbol 'rc'. "rc" is either uninitialized or set to zero here so we can just remove the check. Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap