Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-24 Thread James Hughes
On 23 April 2017 at 20:34, Arend Van Spriel wrote: > On 21-4-2017 11:22, James Hughes wrote: >> On 20 April 2017 at 20:48, Arend van Spriel >> wrote: >>> + linux-wireless >>> >>> On 4/20/2017 1:16 PM, James Hughes wrote: The

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-23 Thread Arend Van Spriel
On 21-4-2017 11:22, James Hughes wrote: > On 20 April 2017 at 20:48, Arend van Spriel > wrote: >> + linux-wireless >> >> On 4/20/2017 1:16 PM, James Hughes wrote: >>> >>> The driver was adding header information to incoming skb >>> without ensuring the head was

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-21 Thread James Hughes
On 20 April 2017 at 20:48, Arend van Spriel wrote: > + linux-wireless > > On 4/20/2017 1:16 PM, James Hughes wrote: >> >> The driver was adding header information to incoming skb >> without ensuring the head was uncloned and hence writable. >> >> skb_cow_head has

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-20 Thread Arend van Spriel
+ linux-wireless On 4/20/2017 1:16 PM, James Hughes wrote: The driver was adding header information to incoming skb without ensuring the head was uncloned and hence writable. skb_cow_head has been used to ensure they are writable, however, this required some changes to error handling to ensure

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-20 Thread Arend van Spriel
On 4/20/2017 2:09 PM, James Hughes wrote: On 20 April 2017 at 12:31, Kalle Valo wrote: + linux-wireless James Hughes writes: The driver was adding header information to incoming skb without ensuring the head was uncloned and hence

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-20 Thread Eric Dumazet
On Thu, 2017-04-20 at 12:16 +0100, James Hughes wrote: > The driver was adding header information to incoming skb > without ensuring the head was uncloned and hence writable. > > skb_cow_head has been used to ensure they are writable, however, > this required some changes to error handling to

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-20 Thread James Hughes
On 20 April 2017 at 12:31, Kalle Valo wrote: > + linux-wireless > > James Hughes writes: > >> The driver was adding header information to incoming skb >> without ensuring the head was uncloned and hence writable. >> >> skb_cow_head has been

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-20 Thread Kalle Valo
+ linux-wireless James Hughes writes: > The driver was adding header information to incoming skb > without ensuring the head was uncloned and hence writable. > > skb_cow_head has been used to ensure they are writable, however, > this required some changes to error

[PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-20 Thread James Hughes
The driver was adding header information to incoming skb without ensuring the head was uncloned and hence writable. skb_cow_head has been used to ensure they are writable, however, this required some changes to error handling to ensure that if skb_cow_head failed it was not ignored. This really