Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
Arend van Spriel writes: >>> This third version is the same as v1 on which I commented to put the >>> coccinelle output in the commit message. So I would still keep v2 if >>> nothing else changed in v3 apart from my Acked-by: tag. >> >> Ok, but I can easily take v3 (ie. this one) so that you get

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
On 5/12/2017 10:54 AM, Kalle Valo wrote: Arend van Spriel writes: On 5/12/2017 10:19 AM, Kalle Valo wrote: Xie Qirong writes: The combination of init_timer and setting up the data and function field manually is equivalent to calling setup_timer(). This is an api consolidation only and impr

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
Arend van Spriel writes: > On 5/12/2017 10:19 AM, Kalle Valo wrote: >> Xie Qirong writes: >> >>> The combination of init_timer and setting up the data and function field >>> manually is equivalent to calling setup_timer(). This is an api >>> consolidation only and improves readability. >>> >>> A

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
On 5/12/2017 10:19 AM, Kalle Valo wrote: Xie Qirong writes: The combination of init_timer and setting up the data and function field manually is equivalent to calling setup_timer(). This is an api consolidation only and improves readability. Acked-by: Arend van Spriel Signed-off-by: Xie Qiro

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
Xie Qirong writes: > The combination of init_timer and setting up the data and function field > manually is equivalent to calling setup_timer(). This is an api > consolidation only and improves readability. > > Acked-by: Arend van Spriel > Signed-off-by: Xie Qirong > --- > > setup_timer.cocci

[PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Xie Qirong
The combination of init_timer and setting up the data and function field manually is equivalent to calling setup_timer(). This is an api consolidation only and improves readability. Acked-by: Arend van Spriel Signed-off-by: Xie Qirong --- setup_timer.cocci suggested the following improvement:

[PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-03 Thread Xie Qirong
setup_timer.cocci suggested the following improvement: drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use setup_timer function for function on line 384. Signed-off-by: Xie Qirong --- Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_USB

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-03 Thread Arend van Spriel
On 5/3/2017 9:35 AM, Xie Qirong wrote: Signed-off-by: Xie Qirong --- setup_timer.cocci suggested the following improvement: drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use setup_timer function for function on line 384. Move the text above before your sign-off so

[PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-03 Thread Xie Qirong
Signed-off-by: Xie Qirong --- setup_timer.cocci suggested the following improvement: drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use setup_timer function for function on line 384. Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_