Re: [PATCH] can: enable multi-queue for SocketCAN devices

On 03/15/2018 10:08 AM, Jonas Mark (BT-FIR/ENG1) wrote: >> Normal SPI? > > Yes, normal SPI (CLK, MOSI, MISO, SEL) plus two GPIOs for flow control. > The CAN peripheral (SPI slave) asserts the additional signals to > request a transfer and to signal that it is busy. Sounds interesting. >>> I

Re: [PATCH] can: enable multi-queue for SocketCAN devices

Hello Marc, > > The driver consists of two layers because the HW is accessed via SPI. > > Normal SPI? Yes, normal SPI (CLK, MOSI, MISO, SEL) plus two GPIOs for flow control. The CAN peripheral (SPI slave) asserts the additional signals to request a transfer and to signal that it is busy. > > I

Re: [PATCH] can: enable multi-queue for SocketCAN devices

On 03/14/2018 05:51 PM, Jonas Mark (BT-FIR/ENG1) wrote: >> That doesn't matter. It would be the first driver that makes use of the >> feature, so we can learn from it. And you might get a free review of >> your driver. > > Of course we would be happy if somebody was volunteering to review > our

Re: [PATCH] can: enable multi-queue for SocketCAN devices

Hello Marc, > >> Do you have a driver or a patch to make a driver mq aware? > > > > Yes, we have CAN hardware with multiple queues and we also have a > > SocketCAN driver for it. > > > > IMHO the driver will be of very little use for the Linux community > > because the HW is proprietary. > >

Re: [PATCH] can: enable multi-queue for SocketCAN devices

On 03/14/2018 01:26 PM, Jonas Mark (BT-FIR/ENG1) wrote: >> Do you have a driver or a patch to make a driver mq aware? > > Yes, we have CAN hardware with multiple queues and we also have a > SocketCAN driver for it. > > IMHO the driver will be of very little use for the Linux community > because

Re: [PATCH] can: enable multi-queue for SocketCAN devices

Hello Marc, > > The existing SocketCAN implementation provides alloc_candev() to > > allocate a CAN device using a single Tx and Rx queue. This can lead to > > priority inversion in case the single Tx queue is already full with low > > priority messages and a high priority message needs to be

[PATCH] can: enable multi-queue for SocketCAN devices

From: Zhu Yi The existing SocketCAN implementation provides alloc_candev() to allocate a CAN device using a single Tx and Rx queue. This can lead to priority inversion in case the single Tx queue is already full with low priority messages and a high priority message needs

Re: [PATCH] can: enable multi-queue for SocketCAN devices

On 03/14/2018 11:33 AM, Mark Jonas wrote: > From: Zhu Yi > > The existing SocketCAN implementation provides alloc_candev() to > allocate a CAN device using a single Tx and Rx queue. This can lead to > priority inversion in case the single Tx queue is already full with low >