Re: [PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-14 Thread David Miller
From: Shyam Saini Date: Sat, 14 Jan 2017 06:47:40 +0530 > The region set by the call to memset, immediately overwritten by > the subsequent call to memcpy and thus makes the memset redundant. > > Also remove the memset((&info, 0, sizeof(info)) on line 398 because > info is memcpy()'ed to before

Re: [PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-14 Thread Tobias Klauser
On 2017-01-14 at 02:17:40 +0100, Shyam Saini wrote: > The region set by the call to memset, immediately overwritten by > the subsequent call to memcpy and thus makes the memset redundant. > > Also remove the memset((&info, 0, sizeof(info)) on line 398 because > info is memcpy()'ed to before bein

[PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-13 Thread Shyam Saini
The region set by the call to memset, immediately overwritten by the subsequent call to memcpy and thus makes the memset redundant. Also remove the memset((&info, 0, sizeof(info)) on line 398 because info is memcpy()'ed to before being used in the loop and it isn't used outside of the loop. Sign

Re: [PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-13 Thread Tobias Klauser
On 2017-01-13 at 10:52:49 +0100, Shyam Saini wrote: > The region set by the call to memset, immediately overwritten by the > subsequent call to memcpy and thus makes the memset redundant > > Signed-off-by: Shyam Saini > --- > drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 --- > 1 file changed

[PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-13 Thread Shyam Saini
The region set by the call to memset, immediately overwritten by the subsequent call to memcpy and thus makes the memset redundant Signed-off-by: Shyam Saini --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/s