Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-12 Thread Tonghao Zhang
On Tue, Sep 12, 2017 at 3:20 AM, Christophe JAILLET wrote: > All other error handling paths in this function go through the 'error' > label. This one should do the same. > > Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") > Signed-off-by: Christophe JAILLET > --- > I think t

Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-12 Thread Greg Rose
On 09/11/2017 12:20 PM, Christophe JAILLET wrote: All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above

Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-11 Thread David Miller
Please use a proper Subject subsystem prefix for openvswitch patches. "datapath" isn't very specific in the global kernel namespace at all. The entire networking stack packet processing path is a "datapath" "openvswitch: " would have been much better.

[PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-11 Thread Christophe JAILLET
All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above the function could be improved. It looks like the c