Re: [PATCH] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-16 Thread David Miller
From: Andrew Lunn Date: Thu, 14 Apr 2016 23:47:12 +0200 > These macros hide a ds variable and a return statement on error, which > can lead to locking issues. Kill them off. > > Signed-off-by: Andrew Lunn Applied, thanks Andrew.

Re: [PATCH] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-14 Thread Vivien Didelot
Andrew Lunn writes: > These macros hide a ds variable and a return statement on error, which > can lead to locking issues. Kill them off. > > Signed-off-by: Andrew Lunn > --- > > As requested by Vivien, this patch has been split out of the series. > > v2: Use the existing ret variable > Hold

[PATCH] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-14 Thread Andrew Lunn
These macros hide a ds variable and a return statement on error, which can lead to locking issues. Kill them off. Signed-off-by: Andrew Lunn --- As requested by Vivien, this patch has been split out of the series. v2: Use the existing ret variable Hold the lock for the whole function, unloc