Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Jay Vosburgh
Stephen Hemminger <[EMAIL PROTECTED]> wrote: >> consider the flow: >> netif_receive_skb() { // occures on eth0 at your picture >> ... >> skb_bond() // changes dev to dev->master >> ... >> handle_bridge() // bridge got the frame >> ... >> deliver_skb() // ETH_P_SLOW bonding handler from ptype_base

Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Stephen Hemminger
On Mon, 10 Apr 2006 22:57:45 +0300 Vlad Drukker <[EMAIL PROTECTED]> wrote: > On Mon, 2006-04-10 at 11:06 -0700, Stephen Hemminger wrote: > > On Mon, 10 Apr 2006 19:28:39 +0200 > > Ingo Oeser <[EMAIL PROTECTED]> wrote: > > > > > Hi Vlad, > > > > > > Vlad Drukker wrote: > > > > diff --git a/net/co

Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Vlad Drukker
On Mon, 2006-04-10 at 11:06 -0700, Stephen Hemminger wrote: > On Mon, 10 Apr 2006 19:28:39 +0200 > Ingo Oeser <[EMAIL PROTECTED]> wrote: > > > Hi Vlad, > > > > Vlad Drukker wrote: > > > diff --git a/net/core/dev.c b/net/core/dev.c > > > index 434220d..a351687 100644 > > > --- a/net/core/dev.c > >

Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Stephen Hemminger
On Mon, 10 Apr 2006 19:28:39 +0200 Ingo Oeser <[EMAIL PROTECTED]> wrote: > Hi Vlad, > > Vlad Drukker wrote: > > diff --git a/net/core/dev.c b/net/core/dev.c > > index 434220d..a351687 100644 > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -1614,6 +1614,8 @@ static __inline__ int handle_b

Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Ingo Oeser
Hi Vlad, Vlad Drukker wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index 434220d..a351687 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1614,6 +1614,8 @@ static __inline__ int handle_bridge(stru > struct net_bridge_port *port; >   > if ((*pskb)->pkt_type ==

[PATCH] fix multicast frame handling

2006-04-10 Thread Vlad Drukker
Hi there, The patch attached. Cheers, Vlad. Signed-off-by: Vlad Drukker <[EMAIL PROTECTED]> --- [PATCH] fix 802.3ad multicast frame handling when bridging two 802.3ad bonds there is a bug. core netif code does handle_bridge before calling protocol handler for ETH_P_SLOW packet_type. when bridge