Re: [PATCH] ftgmac100: return error in ftgmac100_alloc_rx_buf

2017-07-25 Thread David Miller
From: Joel Stanley Date: Tue, 25 Jul 2017 10:19:01 +0930 > The error paths set err, but it's not returned. > > I wondered if we should fix all of the callers to check the returned > value, but Ben explains why the code is this way: > >> Most call sites ignore it on purpose.

[PATCH] ftgmac100: return error in ftgmac100_alloc_rx_buf

2017-07-24 Thread Joel Stanley
The error paths set err, but it's not returned. I wondered if we should fix all of the callers to check the returned value, but Ben explains why the code is this way: > Most call sites ignore it on purpose. There's nothing we can do if > we fail to get a buffer at interrupt time, so we point the