Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-03 Thread Jeff Kirsher
On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > building") > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > function i40e_print_features. > > Fix it. > > Miscellanea: > > o Remove unnecessary string

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread David Miller
From: Joe Perches Date: Wed, 02 Dec 2015 02:12:29 -0800 > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: >> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string >> > building") >> > added defective

[PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread Joe Perches
Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string building") added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in function i40e_print_features. Fix it. Miscellanea: o Remove unnecessary string variable o Add space before not after fixed strings o Use kmalloc not kzalloc

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread Joe Perches
On Wed, 2015-12-02 at 15:48 -0500, David Miller wrote: > From: Joe Perches 02 Dec 2015 02:12:29 -0800 > > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > >> > Noticed-by: Sergei Shtylyov

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread Jeff Kirsher
On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > building") > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > function i40e_print_features. > > Fix it. > > Miscellanea: > > o Remove unnecessary string

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread Joe Perches
On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > > building") > > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > > function i40e_print_features. >