Re: [PATCH] i40e: don't truncate match_method assignment

2016-12-10 Thread David Miller
From: Jacob Keller Date: Fri, 9 Dec 2016 13:39:21 -0800 > The .match_method field is a u8, so we shouldn't be casting to a u16, > and because it is only one byte, we do not need to byte swap anything. > Just assign the value directly. This avoids issues on Big Endian > architectures which would

Re: [PATCH] i40e: don't truncate match_method assignment

2016-12-09 Thread David Miller
From: Jacob Keller Date: Fri, 9 Dec 2016 13:39:21 -0800 > The .match_method field is a u8, so we shouldn't be casting to a u16, > and because it is only one byte, we do not need to byte swap anything. > Just assign the value directly. This avoids issues on Big Endian > architectures which would

[PATCH] i40e: don't truncate match_method assignment

2016-12-09 Thread Jacob Keller
The .match_method field is a u8, so we shouldn't be casting to a u16, and because it is only one byte, we do not need to byte swap anything. Just assign the value directly. This avoids issues on Big Endian architectures which would have byte swapped and then incorrectly truncated the value. Signed