Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-05-02 Thread Wang Shanker
Thanks a lot. I feel it excited to contribute to the development of kernel. I’ll do better next time. > 在 2016年5月3日,06:19,Stephen Hemminger 写道: > > On Thu, 28 Apr 2016 15:50:47 +0100 > James Chapman wrote: > >> Yes, that looks like the problem. >> >> The comments in l2tp.h which indicate th

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-05-02 Thread Stephen Hemminger
On Thu, 28 Apr 2016 15:50:47 +0100 James Chapman wrote: > Yes, that looks like the problem. > > The comments in l2tp.h which indicate that the csum attributes are u8 > values are wrong. Code in net/l2tp/l2tp_netlink.c accesses these > attributes using nla_get_flag(). > > Please submit a patch t

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-28 Thread James Chapman
Yes, that looks like the problem. The comments in l2tp.h which indicate that the csum attributes are u8 values are wrong. Code in net/l2tp/l2tp_netlink.c accesses these attributes using nla_get_flag(). Please submit a patch to fix l2tp_tunnel_sock_create(). Include good change notes and your sign

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-27 Thread Wang Shanker
> 在 2016年4月27日,23:33,Wang Shanker 写道: > > > >> 在 2016年4月27日,20:21,James Chapman 写道: >> >> On 26 April 2016 at 15:15, Wang Shanker wrote: >>> Hi, all >>> >>> It’s my first time to contribute to such an important open source project. >>> Things began when I upgraded my server, called "Serv

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-27 Thread Wang Shanker
> 在 2016年4月27日,20:21,James Chapman 写道: > > On 26 April 2016 at 15:15, Wang Shanker wrote: >> Hi, all >> >> It’s my first time to contribute to such an important open source project. >> Things began when I upgraded my server, called "Server A", form ubuntu 14.04 >> to 16.04, which is shipped

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-27 Thread James Chapman
On 26 April 2016 at 15:15, Wang Shanker wrote: > Hi, all > > It’s my first time to contribute to such an important open source project. > Things began when I upgraded my server, called "Server A", form ubuntu 14.04 > to 16.04, which is shipped with new kernel version, 4.4. After upgrade, I > so

[PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-26 Thread Wang Shanker
Hi, all It’s my first time to contribute to such an important open source project. Things began when I upgraded my server, called "Server A", form ubuntu 14.04 to 16.04, which is shipped with new kernel version, 4.4. After upgrade, I soon found a l2tp tunnel between this server and another linu