Re: [PATCH] kernel: bpf: remove dead code

2017-05-22 Thread Daniel Borkmann
On 05/22/2017 06:27 PM, David Miller wrote: [...] Ok I understand the issue now. Thanks for explaining. I guess a hard-coded value of 2 and an adjusted comment above the assignment of ip_align is the way to go. I'll push the following, thanks everyone: net: Make IP alignm

Re: [PATCH] kernel: bpf: remove dead code

2017-05-22 Thread David Miller
From: Daniel Borkmann Date: Mon, 22 May 2017 16:52:24 +0200 > On 05/22/2017 04:38 PM, David Miller wrote: >> From: "Gustavo A. R. Silva" >> Date: Mon, 22 May 2017 09:07:46 -0500 >> >>> Execution cannot reach NET_IP_ALIGN inside the following statement: >>> ip_align = strict ? 2 : NET_IP_ALIGN >>

Re: [PATCH] kernel: bpf: remove dead code

2017-05-22 Thread Daniel Borkmann
On 05/22/2017 04:38 PM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Mon, 22 May 2017 09:07:46 -0500 Execution cannot reach NET_IP_ALIGN inside the following statement: ip_align = strict ? 2 : NET_IP_ALIGN Addresses-Coverity-ID: 1409762 Signed-off-by: Gustavo A. R. Silva --- NOTE: v

Re: [PATCH] kernel: bpf: remove dead code

2017-05-22 Thread Gustavo A. R. Silva
Hi David, Quoting David Miller : From: "Gustavo A. R. Silva" Date: Mon, 22 May 2017 09:07:46 -0500 Execution cannot reach NET_IP_ALIGN inside the following statement: ip_align = strict ? 2 : NET_IP_ALIGN Addresses-Coverity-ID: 1409762 Signed-off-by: Gustavo A. R. Silva --- NOTE: variable i

Re: [PATCH] kernel: bpf: remove dead code

2017-05-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 22 May 2017 09:07:46 -0500 > Execution cannot reach NET_IP_ALIGN inside the following statement: > ip_align = strict ? 2 : NET_IP_ALIGN > > Addresses-Coverity-ID: 1409762 > Signed-off-by: Gustavo A. R. Silva > --- > NOTE: variable ip_align could also be re

[PATCH] kernel: bpf: remove dead code

2017-05-22 Thread Gustavo A. R. Silva
Execution cannot reach NET_IP_ALIGN inside the following statement: ip_align = strict ? 2 : NET_IP_ALIGN Addresses-Coverity-ID: 1409762 Signed-off-by: Gustavo A. R. Silva --- NOTE: variable ip_align could also be removed and use value 2 directly. kernel/bpf/verifier.c | 2 +- 1 file changed, 1