[PATCH] libertas: fix possible NULL dereference

2015-11-23 Thread Sudip Mukherjee
We were dereferencing cmd first and checking for NULL later. Lets first check for NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/marvell/libertas/cfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] libertas: fix possible NULL dereference

2015-11-23 Thread Andy Shevchenko
On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee wrote: > We were dereferencing cmd first and checking for NULL later. Lets first > check for NULL. However the patch is valid due to reducing error prone part, the commit message seems wrong. There is no dereferencing,

Re: [PATCH] libertas: fix possible NULL dereference

2015-11-23 Thread Sudip Mukherjee
On Tue, Nov 24, 2015 at 01:43:38AM +0200, Andy Shevchenko wrote: > On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee > wrote: > > We were dereferencing cmd first and checking for NULL later. Lets first > > check for NULL. > > However the patch is valid due to reducing