From: Eric Dumazet [EMAIL PROTECTED]
Date: Tue, 06 Sep 2005 01:51:16 +0200
Avoid touching file-f_dentry on sockets, since file-private_data directly
gives us the socket pointer.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
Applied, thanks Eric.
-
To unsubscribe from this list: send the
Benjamin LaHaise a écrit :
Please consider the patch below which makes use of file-private_data
to store the pointer to the socket, which avoids touching several
unused cachelines in the dentry and inode in sockfd_lookup.
Hi David
Could you please apply this patch, in continuation of
Andi Kleen a écrit :
David, do you think we could place file-private_data in the same cache
line than file-f_count and file-f_op, so that sockfd_lookup() can access
all the needed information (f_count, f_op, private_data) using one
L1_CACHE_LINE only ?
You mean for 32byte cache lines? Not
No no, the private_data is actually far beyond, even for a L1_CACHE_LINE of
128 bytes
Yuck.
(because of the insane struct file_ra_state f_ra. I wish this structure
were dynamically allocated only for files that really use it)
How about you submit a patch for that instead?
-Andi
-
To
Here is a resend properly signed off.
Please consider the patch below which makes use of file-private_data to
store the pointer to the socket, which avoids touching several unused
cachelines in the dentry and inode in sockfd_lookup.
Signed-off-by: Benjamin LaHaise [EMAIL PROTECTED]
diff -purN
