Re: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter

2015-09-15 Thread David Miller
From: Joe Perches Date: Wed, 09 Sep 2015 17:40:56 -0700 > The code around the allocation and loops are a bit obfuscated. > > Neaten it by using: > > o kcalloc with decimal count and sizeof(u32) > o Decimal loop indexing and i++ not i += 4 > o A promiscuous block using a

[PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter

2015-09-09 Thread Joe Perches
The code around the allocation and loops are a bit obfuscated. Neaten it by using: o kcalloc with decimal count and sizeof(u32) o Decimal loop indexing and i++ not i += 4 o A promiscuous block using a similar style to the multicast block o Remove unnecessary variables Signed-off-by: Joe