Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

2018-05-09 Thread Saeed Mahameed
On Wed, 2018-05-09 at 15:19 -0700, Guenter Roeck wrote: > On Sun, May 06, 2018 at 09:33:26AM +0200, Thomas Gleixner wrote: > > On Sat, 5 May 2018, Guenter Roeck wrote: > > > > > On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > > > > Adding the vector offset when calling to mlx5_ve

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

2018-05-09 Thread Guenter Roeck
On Sun, May 06, 2018 at 09:33:26AM +0200, Thomas Gleixner wrote: > On Sat, 5 May 2018, Guenter Roeck wrote: > > > On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > > > Adding the vector offset when calling to mlx5_vector2eqn() is wrong. > > > This is because mlx5_vector2eqn() check

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

2018-05-06 Thread Thomas Gleixner
On Sun, 6 May 2018, Thomas Gleixner wrote: > On Sat, 5 May 2018, Guenter Roeck wrote: > > > -#ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK > > > - mask = irq_data_get_effective_affinity_mask(&desc->irq_data); > > > -#else > > > - mask = desc->irq_common_data.affinity; > > > -#endif > > > - return ma

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

2018-05-06 Thread Thomas Gleixner
On Sat, 5 May 2018, Guenter Roeck wrote: > On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > > Adding the vector offset when calling to mlx5_vector2eqn() is wrong. > > This is because mlx5_vector2eqn() checks if EQ index is equal to vector > > number > > and the fact that the inte

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

2018-05-05 Thread Guenter Roeck
On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > Adding the vector offset when calling to mlx5_vector2eqn() is wrong. > This is because mlx5_vector2eqn() checks if EQ index is equal to vector number > and the fact that the internal completion vectors that mlx5 allocates > don't get