[PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Yuusuke Ashiduka
If highmem and 2GB or more of memory are valid, "this_frag-> page.p" indicates the highmem area, so the result of page_address() is NULL and panic occurs. This commit fixes this by using the skb_frag_dma_map() helper, which takes care of mapping the skb fragment properly. Additionally, the type of

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Andy Duan
From: Yuusuke Ashiduka Sent: Tuesday, January 17, 2017 3:48 PM >To: Andy Duan >Cc: netdev@vger.kernel.org; Yuusuke Ashiduka >Subject: [PATCH] net: fec: Fixed panic problem with non-tso > >If highmem and 2GB or more of memory are valid, "this_frag-> page.p" >ind

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread David Miller
From: Yuusuke Ashiduka Date: Tue, 17 Jan 2017 16:48:20 +0900 > If highmem and 2GB or more of memory are valid, > "this_frag-> page.p" indicates the highmem area, > so the result of page_address() is NULL and panic occurs. > > This commit fixes this by using the skb_frag_dma_map() helper, > which

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Ashizuka, Yuusuke
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, January 18, 2017 5:45 AM > To: Ashizuka, Yuusuke/芦塚 雄介 > Cc: fugang.d...@nxp.com; netdev@vger.kernel.org > Subject: Re: [PATCH] net: fec: Fixed panic problem with non-tso > >

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Ashizuka, Yuusuke
> -Original Message- > From: Andy Duan [mailto:fugang.d...@nxp.com] > Sent: Tuesday, January 17, 2017 8:02 PM > To: Ashizuka, Yuusuke/芦塚 雄介 > Cc: netdev@vger.kernel.org > Subject: RE: [PATCH] net: fec: Fixed panic problem with non-tso > > From: Yuusuke Ashiduka

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Eric Dumazet
On Wed, 2017-01-18 at 03:12 +, Ashizuka, Yuusuke wrote: > indeed. > > In the case of TSO with i.MX6 system (highmem enabled) with 2GB memory, > "this_frag->page.p" did not become highmem area. > (We confirmed by transferring about 100MB of files) > > However, in the case of non-tso on an i.M

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Eric Dumazet
On Tue, 2017-01-17 at 20:21 -0800, Eric Dumazet wrote: > On Wed, 2017-01-18 at 03:12 +, Ashizuka, Yuusuke wrote: > > > indeed. > > > > In the case of TSO with i.MX6 system (highmem enabled) with 2GB memory, > > "this_frag->page.p" did not become highmem area. > > (We confirmed by transferring

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-18 Thread Pravin Shelar
On Tue, Jan 17, 2017 at 8:35 PM, Eric Dumazet wrote: > On Tue, 2017-01-17 at 20:21 -0800, Eric Dumazet wrote: >> On Wed, 2017-01-18 at 03:12 +, Ashizuka, Yuusuke wrote: >> >> > indeed. >> > >> > In the case of TSO with i.MX6 system (highmem enabled) with 2GB memory, >> > "this_frag->page.p" di

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 10:18 -0800, Pravin Shelar wrote: \ > Right, this high mem check should be decoupled from csum check. I must say I am surprised nobody hit this problem before today. linux-3.10 is more than 3 years old.

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-19 Thread Andy Duan
From: Eric Dumazet Sent: Wednesday, January 18, 2017 12:36 PM >To: Ashizuka, Yuusuke >Cc: Andy Duan ; netdev@vger.kernel.org; Pravin B >Shelar >Subject: Re: [PATCH] net: fec: Fixed panic problem with non-tso > >On Tue, 2017-01-17 at 20:21 -0800, Eric Dumazet wrote: >>

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-19 Thread Eric Dumazet
On Thu, 2017-01-19 at 08:18 +, Andy Duan wrote: > I will double check your fix. Thanks. > > And, if driver is to support highmem, then we should add tso highmem > support in net/core/tso.c, do you think it is necessary ? Adding TSO highmem support would mean changing net/core/tso.c ABI an