Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

2018-01-23 Thread Gustavo A. R. Silva
Quoting David Miller : [..] Please don't use the word "fix". '0' is the same as 'false', it's just that the latter is more consistent type wise. So "Use true and false for boolean value" would be a better subject? Yes. I got it. Thanks -- Gustavo

Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

2018-01-23 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 23 Jan 2018 09:21:00 -0600 > > Quoting David Miller : > >> From: "Gustavo A. R. Silva" >> Date: Mon, 22 Jan 2018 16:22:13 -0600 >> >>> Assign true or false to boolean variables

Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

2018-01-23 Thread Gustavo A. R. Silva
Quoting David Miller : From: "Gustavo A. R. Silva" Date: Mon, 22 Jan 2018 16:22:13 -0600 Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: 1cb3fe513f62 ("ndisc:

Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

2018-01-23 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 22 Jan 2018 16:22:13 -0600 > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build

[PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

2018-01-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build message directly.") Signed-off-by: Gustavo A. R. Silva --- net/ipv6/ndisc.c