Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Hauke Mehrtens
On 12/21/20 7:04 PM, Andrew Lunn wrote: On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: The declaration of request_irq() in is marked as __must_check. Witho

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Andrew Lunn
On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: > On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > > The declaration of request_irq() in is marked as > > > __must_check. > > > > > > Without the return

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Miguel Ojeda
On Mon, Dec 21, 2020 at 6:01 PM Andrew Lunn wrote: > > So please leave the warning in place, and maybe somebody else will > fully fix it. For context: the plan is to enable the warning unconditionally starting with 5.11. After that, the idea is making it an error as soon as reasonable (e.g. 5.12

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Andrew Lunn
On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: > On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > > The declaration of request_irq() in is marked as > > > __must_check. > > > > > > Without the return

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Masahiro Yamada
On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > The declaration of request_irq() in is marked as > > __must_check. > > > > Without the return value check, I see the following warnings: > > > > drivers/net/ethernet/lantiq

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Andrew Lunn
On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > The declaration of request_irq() in is marked as > __must_check. > > Without the return value check, I see the following warnings: > > drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_hw_init': > drivers/net/ethernet/lan

[PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-20 Thread Masahiro Yamada
The declaration of request_irq() in is marked as __must_check. Without the return value check, I see the following warnings: drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_hw_init': drivers/net/ethernet/lantiq_etop.c:273:4: warning: ignoring return value of 'request_irq', declared wi