Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-28 Thread Andrew Collins
From: Cong Wang > If this is just an iproute2 issue, please fix it there rather in kernel. I'm fine with fixing this as a documentation issue (fix being change man page, MTU "Defaults to unlimited" to "Defaults to 2047"). Note however this does mean that tc-police

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-28 Thread Cong Wang
On Tue, Feb 27, 2018 at 9:41 AM, Andrew Collins wrote: >> I don't find such statement from the man page: >> http://man7.org/linux/man-pages/man8/tc-police.8.html > > >> What am I missing? > > Under MTU the man page states: > > mtu BYTES[/BYTES] > This is

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-27 Thread Andrew Collins
> I don't find such statement from the man page: > http://man7.org/linux/man-pages/man8/tc-police.8.html > What am I missing? Under MTU the man page states: mtu BYTES[/BYTES] This is the maximum packet size handled by the policer (larger ones will be handled like they

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-26 Thread Cong Wang
On Mon, Feb 26, 2018 at 12:10 PM, Andrew Collins wrote: > The man page for tc-police states that the MTU defaults to > unlimited if peakrate is not specified, but it actually defaults > to 2047. I don't find such statement from the man page:

[PATCH] net: make tc-police action MTU behavior match documentation

2018-02-26 Thread Andrew Collins
The man page for tc-police states that the MTU defaults to unlimited if peakrate is not specified, but it actually defaults to 2047. This causes issues with GRO enabled interfaces, as >2047 coalesced packets get dropped and the resulting rate is wildly inaccurate. Fix by only setting the default