Re: [PATCH] net: qcom/emac: make function emac_isr static

2017-10-05 Thread David Miller
From: Colin King Date: Thu, 5 Oct 2017 10:10:23 +0100 > From: Colin Ian King > > The function emac_isr is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warnings: > symbol 'emac_isr' was not declared. Should it be static? > > Signed-off

Re: [PATCH] net: qcom/emac: make function emac_isr static

2017-10-05 Thread Timur Tabi
On 10/05/2017 04:10 AM, Colin King wrote: From: Colin Ian King The function emac_isr is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warnings: symbol 'emac_isr' was not declared. Should it be static? Signed-off-by: Colin Ian King ACK -- Qu

[PATCH] net: qcom/emac: make function emac_isr static

2017-10-05 Thread Colin King
From: Colin Ian King The function emac_isr is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warnings: symbol 'emac_isr' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/net/ethernet/qualcomm/emac/emac.c | 2 +-