[PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-14 Thread Du Cheng
There is a reproducible sequence from the userland that will trigger a WARN_ON() condition in taprio_get_start_time, which causes kernel to panic if configured as "panic_on_warn". Remove this WARN_ON() to prevent kernel from crashing by userland-initiated syscalls. Reported as bug on syzkaller: ht

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-14 Thread Eric Dumazet
On 4/15/21 8:39 AM, Du Cheng wrote: > There is a reproducible sequence from the userland that will trigger a > WARN_ON() > condition in taprio_get_start_time, which causes kernel to panic if configured > as "panic_on_warn". Remove this WARN_ON() to prevent kernel from crashing by > userland-ini

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread Du Cheng
Le Thu, Apr 15, 2021 at 08:56:09AM +0200, Eric Dumazet a écrit : > > > On 4/15/21 8:39 AM, Du Cheng wrote: > > There is a reproducible sequence from the userland that will trigger a > > WARN_ON() > > condition in taprio_get_start_time, which causes kernel to panic if > > configured > > as "pani

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread kernel test robot
Hi Du, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.12-rc7 next-20210414] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread kernel test robot
Hi Du, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc7 next-20210414] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread Eric Dumazet
On 4/15/21 9:50 AM, Du Cheng wrote: > Le Thu, Apr 15, 2021 at 08:56:09AM +0200, Eric Dumazet a écrit : >> >> >> On 4/15/21 8:39 AM, Du Cheng wrote: >>> There is a reproducible sequence from the userland that will trigger a >>> WARN_ON() >>> condition in taprio_get_start_time, which causes kerne

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread kernel test robot
Hi Du, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc7 next-20210415] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https