Re: [PATCH] net: thunderx: add support for rgmii internal delay

2017-12-18 Thread Tim Harvey
On Thu, Dec 14, 2017 at 12:45 AM, Andrew Lunn wrote: > On Wed, Dec 13, 2017 at 03:28:33PM -0800, Tim Harvey wrote: >> On Wed, Dec 13, 2017 at 3:10 AM, Andrew Lunn wrote: >> >> +void xcv_init_hw(int phy_mode) >> >> { >> >> u64 cfg; >> >> >> >> @@ -81,12

Re: [PATCH] net: thunderx: add support for rgmii internal delay

2017-12-14 Thread Andrew Lunn
On Wed, Dec 13, 2017 at 03:28:33PM -0800, Tim Harvey wrote: > On Wed, Dec 13, 2017 at 3:10 AM, Andrew Lunn wrote: > >> +void xcv_init_hw(int phy_mode) > >> { > >> u64 cfg; > >> > >> @@ -81,12 +81,31 @@ void xcv_init_hw(void) > >> /* Wait for DLL to lock */ > >>

Re: [PATCH] net: thunderx: add support for rgmii internal delay

2017-12-13 Thread Tim Harvey
On Wed, Dec 13, 2017 at 3:10 AM, Andrew Lunn wrote: >> +void xcv_init_hw(int phy_mode) >> { >> u64 cfg; >> >> @@ -81,12 +81,31 @@ void xcv_init_hw(void) >> /* Wait for DLL to lock */ >> msleep(1); >> >> - /* Configure DLL - enable or bypass >> - * TX

Re: [PATCH] net: thunderx: add support for rgmii internal delay

2017-12-13 Thread Andrew Lunn
> +void xcv_init_hw(int phy_mode) > { > u64 cfg; > > @@ -81,12 +81,31 @@ void xcv_init_hw(void) > /* Wait for DLL to lock */ > msleep(1); > > - /* Configure DLL - enable or bypass > - * TX no bypass, RX bypass > - */ > + /* enable/bypass DLL providing MAC

[PATCH] net: thunderx: add support for rgmii internal delay

2017-12-12 Thread Tim Harvey
The XCV_DLL_CTL is being configured with the assumption that phy-mode is rgmii-txid (PHY_INTERFACE_MODE_RGMII_TXID) which is not always the case. This patch parses the phy-mode property and uses it to configure CXV_DLL_CTL properly. Signed-off-by: Tim Harvey ---