From: Arnd Bergmann
The commit 899077791403 ("netcp: try to reduce type confusion in descriptors")
introduces a regression in Kernel 4.5-rc1 and it breaks
get/set_pad_info() functionality.
The TI NETCP driver uses pad0 and pad1 fields of knav_dma_desc to
store DMA/MEM buffer pointer and buffer s
From: Grygorii Strashko
> Sent: 09 February 2016 13:58
> From: Arnd Bergmann
>
> The commit 899077791403 ("netcp: try to reduce type confusion in descriptors")
> introduces a regression in Kernel 4.5-rc1 and it breaks
> get/set_pad_info() functionality.
>
> The TI NETCP driver uses pad0 and pad1
From: Karicheri, Muralidharan
> Sent: 09 February 2016 16:10
...
> >In reality the 'pad' fields ought to be renamed - since they aren't pads.
> >Perhaps they should be a union?
> No. At the end of the descriptor, host software can add scratchpad which is
> not modified by the hardware, but is used
Kwok,
>WingMan;
>Karicheri, Muralidharan; N, Mugunthan V
>Subject: RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
>
>From: Grygorii Strashko
>> Sent: 09 February 2016 13:58
>> From: Arnd Bergmann
>>
>> The commit 899077791403 ("netcp: tr
;Arnd Bergmann
>Cc: Cooper Jr., Franklin; Nori, Sekhar; linux-ker...@vger.kernel.org; Kwok,
>WingMan; N,
>Mugunthan V
>Subject: RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
>
>From: Karicheri, Muralidharan
>> Sent: 09 February 2016 16:10
>...
>&g
From: Karicheri, Muralidharan
> Sent: 09 February 2016 16:19
> >...
> >> >In reality the 'pad' fields ought to be renamed - since they aren't pads.
> >> >Perhaps they should be a union?
> >
> >> No. At the end of the descriptor, host software can add scratchpad
> >> which is not modified by the har
ri, Sekhar; linux-ker...@vger.kernel.org; Kwok,
>WingMan; N,
>Mugunthan V
>Subject: RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
>
>From: Karicheri, Muralidharan
>> Sent: 09 February 2016 16:19
>> >...
>> >> >In reality the 'pad' fie
On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
>
> The descriptors are usable by different drivers, one driver may use it as
> buf ptr/ len, other for something else. So they should remain as generic
> and it is up to individual drivers to use it in whatever way it requires.
Hi All,
On 02/09/2016 09:38 PM, Arnd Bergmann wrote:
> On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
>>
>> The descriptors are usable by different drivers, one driver may use it as
>> buf ptr/ len, other for something else. So they should remain as generic
>> and it is up to
I would like some of the feedback to be taken into consideration and
integrated into this patch.
Part of the reason this regression was introduced was probably because
the purpose of some fields or descriptor semantics was not defined
properly.
Therefore it is absolutely appropriate to properly
On 02/09/2016 02:38 PM, Arnd Bergmann wrote:
> On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
>> The descriptors are usable by different drivers, one driver may use it as
>> buf ptr/ len, other for something else. So they should remain as generic
>> and it is up to individual
On 02/09/2016 02:38 PM, Arnd Bergmann wrote:
> On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
>>
>> The descriptors are usable by different drivers, one driver may use it as
>> buf ptr/ len, other for something else. So they should remain as generic
>> and it is up to individu
On 02/16/2016 03:24 PM, David Miller wrote:
>
> I would like some of the feedback to be taken into consideration and
> integrated into this patch.
>
> Part of the reason this regression was introduced was probably because
> the purpose of some fields or descriptor semantics was not defined
> prop
From: Murali Karicheri
Date: Thu, 18 Feb 2016 12:13:10 -0500
> On 02/16/2016 03:24 PM, David Miller wrote:
>>
>> I would like some of the feedback to be taken into consideration and
>> integrated into this patch.
>>
>> Part of the reason this regression was introduced was probably because
>> th
14 matches
Mail list logo
