Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

2018-06-16 Thread David Miller
From: Konstantin Khlebnikov Date: Fri, 15 Jun 2018 13:27:31 +0300 > When blackhole is used on top of classful qdisc like hfsc it breaks > qlen and backlog counters because packets are disappear without notice. > > In HFSC non-zero qlen while all classes are inactive triggers warning: > WARNING:

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

2018-06-15 Thread Cong Wang
On Fri, Jun 15, 2018 at 9:00 PM, Cong Wang wrote: > On Fri, Jun 15, 2018 at 6:21 AM, Konstantin Khlebnikov > wrote: >> On 15.06.2018 16:13, Eric Dumazet wrote: >>> >>> >>> >>> On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: When blackhole is used on top of classful qdisc like hfsc

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

2018-06-15 Thread Cong Wang
On Fri, Jun 15, 2018 at 6:21 AM, Konstantin Khlebnikov wrote: > On 15.06.2018 16:13, Eric Dumazet wrote: >> >> >> >> On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: >>> >>> When blackhole is used on top of classful qdisc like hfsc it breaks >>> qlen and backlog counters because packets are di

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

2018-06-15 Thread Konstantin Khlebnikov
On 15.06.2018 16:13, Eric Dumazet wrote: On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: When blackhole is used on top of classful qdisc like hfsc it breaks qlen and backlog counters because packets are disappear without notice. In HFSC non-zero qlen while all classes are inactive trigge

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

2018-06-15 Thread Eric Dumazet
On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: > When blackhole is used on top of classful qdisc like hfsc it breaks > qlen and backlog counters because packets are disappear without notice. > > In HFSC non-zero qlen while all classes are inactive triggers warning: > WARNING: ... at net/s

[PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

2018-06-15 Thread Konstantin Khlebnikov
When blackhole is used on top of classful qdisc like hfsc it breaks qlen and backlog counters because packets are disappear without notice. In HFSC non-zero qlen while all classes are inactive triggers warning: WARNING: ... at net/sched/sch_hfsc.c:1393 hfsc_dequeue+0xba4/0xe90 [sch_hfsc] and sched