Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-20 Thread Eric Dumazet
On Thu, Apr 20, 2017 at 12:08 PM, tndave wrote: > > > On 04/12/2017 03:37 PM, tndave wrote: >> >> >> >> On 04/06/2017 12:14 PM, Eric Dumazet wrote: >>> >>> On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: >>> > +q_index = q_index %

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-20 Thread tndave
On 04/12/2017 03:37 PM, tndave wrote: On 04/06/2017 12:14 PM, Eric Dumazet wrote: On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: +q_index = q_index % dev->real_num_tx_queues; cpu interrupted here and dev->real_num_tx_queues has reduced! +

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-12 Thread tndave
On 04/06/2017 12:14 PM, Eric Dumazet wrote: On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: + q_index = q_index % dev->real_num_tx_queues; cpu interrupted here and dev->real_num_tx_queues has reduced! + skb_set_queue_mapping(skb, q_index); +

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-06 Thread Eric Dumazet
On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: > > + q_index = q_index % dev->real_num_tx_queues; > cpu interrupted here and dev->real_num_tx_queues has reduced! > > + skb_set_queue_mapping(skb, q_index); > > + } > > + txq =

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-06 Thread tndave
On 04/06/2017 03:26 AM, Eric Dumazet wrote: On Wed, 2017-04-05 at 19:06 -0700, Tushar Dave wrote: Reducing real_num_tx_queues needs to be in sync with skb queue_mapping otherwise skbs with queue_mapping greater than real_num_tx_queues can be sent to the underlying driver and can result in

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-06 Thread Eric Dumazet
On Thu, 2017-04-06 at 03:26 -0700, Eric Dumazet wrote: > Hi Thushar, thank you for working on this issue. I am sorry for the typo Tushar ! Thanks !

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-06 Thread Eric Dumazet
On Wed, 2017-04-05 at 19:06 -0700, Tushar Dave wrote: > Reducing real_num_tx_queues needs to be in sync with skb queue_mapping > otherwise skbs with queue_mapping greater than real_num_tx_queues > can be sent to the underlying driver and can result in kernel panic. > > One such event is running

[PATCH] netpoll: Check for skb->queue_mapping

2017-04-05 Thread Tushar Dave
Reducing real_num_tx_queues needs to be in sync with skb queue_mapping otherwise skbs with queue_mapping greater than real_num_tx_queues can be sent to the underlying driver and can result in kernel panic. One such event is running netconsole and enabling VF on the same device. Or running