Re: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-31 Thread Joe Perches
On Wed, 2016-07-27 at 07:24 +, Yuval Mintz wrote: > > > > Current DP_ macros generate a lot of code. > > Using functions with vsprintf extension %pV helps reduce that size. > > > >  drivers/net/ethernet/qlogic/qed/Makefile   |  2 +- > >  drivers/net/ethernet/qlogic/qed/qed_util.c | 82 > >

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-30 Thread kbuild test robot
Hi, [auto build test ERROR on net-next/master] [also build test ERROR on v4.7 next-20160729] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-27 Thread Yuval Mintz
> Current DP_ macros generate a lot of code. > Using functions with vsprintf extension %pV helps reduce that size. > > drivers/net/ethernet/qlogic/qed/Makefile | 2 +- > drivers/net/ethernet/qlogic/qed/qed_util.c | 82 > ++ > include/linux/qed/qed_if.h

RE: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-27 Thread Yuval Mintz
> > Current DP_ macros generate a lot of code. > > Using functions with vsprintf extension %pV helps reduce that size. > > Yuval, I used the same KERN_ output types, but it is unusual > that DP_INFO outputs at KERN_NOTICE. > > Was that a copy/paste defect or should it be emitted at KERN_INFO and

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
On Tue, 2016-07-26 at 14:25 -0700, Joe Perches wrote: > Current DP_ macros generate a lot of code. > Using functions with vsprintf extension %pV helps reduce that size. Yuval, I used the same KERN_ output types, but it is unusual that DP_INFO outputs at KERN_NOTICE. Was that a copy/paste defect

[PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
Current DP_ macros generate a lot of code. Using functions with vsprintf extension %pV helps reduce that size. $ size drivers/net/ethernet/qlogic/built-in.o* (x86-64) textdata bss dec hex filename 165161 28470 32812 226443 3748b