[PATCH] qlcnic: constify qlcnic_mbx_ops structure

2015-10-11 Thread Julia Lawall
The only instance of a qlcnic_mbx_ops structure is never modified. Thus the declaration of the structure and all references to the structure type can be made const. In the definition of the qlcnic_mailbox structure, the ops field is no longer lined up with the other fields. This was left as is,

RE: [PATCH] qlcnic: constify qlcnic_mbx_ops structure

2015-10-12 Thread Sony Chacko
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Julia Lawall > Sent: Sunday, October 11, 2015 4:48 AM > To: Dept-GE Linux NIC Dev > Cc: kernel-janit...@vger.kernel.org; netdev ; linux- > kernel > Subject: [PA

Re: [PATCH] qlcnic: constify qlcnic_mbx_ops structure

2015-10-13 Thread David Miller
From: Julia Lawall Date: Sun, 11 Oct 2015 13:48:05 +0200 > The only instance of a qlcnic_mbx_ops structure is never modified. Thus > the declaration of the structure and all references to the structure type > can be made const. > > In the definition of the qlcnic_mailbox structure, the ops fiel