Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

2016-06-26 Thread Larry Finger
On 06/26/2016 08:26 PM, Joe Perches wrote: On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: On 06/26/2016 02:34 PM, Joe Perches wrote: RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

2016-06-26 Thread Joe Perches
On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: > On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > > > > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > > > > > > RT_TRACE does not add a newline to the end of a message and always > > > emits at KERN_DEBUG so these are

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

2016-06-26 Thread Joe Perches
On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > RT_TRACE does not add a newline to the end of a message and always > > emits at KERN_DEBUG so these are susceptible to message interleaving > > from other processes without the newline. > >

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

2016-06-26 Thread Larry Finger
On 06/26/2016 02:34 PM, Joe Perches wrote: RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these are susceptible to message interleaving from other processes without the newline. Signed-off-by: Joe Perches --- This patch does not

[PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

2016-06-26 Thread Joe Perches
RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these are susceptible to message interleaving from other processes without the newline. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/core.c| 2 +-